Feature: Multidoor

[luckykadam]

New Feature: Multidoor !
You can now add multiple door/windows under one arch.

Other changes:

1. Now arch is supported by wall at any angle
2. Consistent window and door frame structure
3. Cleaner UI

fixes #38

[ranjian0]

Still reviewing but here are some quick comments:

• Not sure if arch did this before, but now there is an extra n-gon behind the arch faces.
• FillTypes for this feel inconsistent. we should consider giving an option for separate fill for door and window.
• Also Components property UI is too tight, consider using a column with a label and the property.
• FaceMaps for this tool not working

[luckykadam]

@ranjian0
We can provide different fill types for door, window and archs. But, when the user wants same fill type for all these, it should happen with single fill type settings, which is not possible in current FillType implementation.

This situation can be fixed cleanly while working on #39
I can take up that task

[ranjian0]

@ranjian0
We can provide different fill types for door, window and archs. But, when the user wants same fill type for all these, it should happen with single fill type settings, which is not possible in current FillType implementation.

This situation can be fixed cleanly while working on #39
I can take up that task

That's fine,

[ranjian0]

The common module in core feels misplaced. I'd feel better if common/arch.py and common/frame.py were just files in core like generic.py and register.py.

This could be solved better with a new directory structure.

Also, the name Multidoor for this feels onesided. The tool creates both doors and windows.

[luckykadam]

The common module in core feels misplaced. I'd feel better if common/arch.py and common/frame.py were just files in core like generic.py and register.py.

I will move them to core/arch.py and core/frame.py.

Also, the name Multidoor for this feels onesided. The tool creates both doors and windows.

I could not come up with a better name. You can suggest something?

[ranjian0]

Multigroup perhaps. With the UI giving a relationship to Window and Door.

[ranjian0]

Will merge this. Deal with bugs over the weekend.
This is a really good feature. Great Work.