Skip to content

Commit

Permalink
[Fix] Correct dependency for building libhphp_java.so
Browse files Browse the repository at this point in the history
Summary:
The java .so is built from PIC_OBJECTS now, so the dependency should be from
PIC_OBJECTS. Otherwise, we might compile the .cpp file before generating the .h
file.

Quite a few libcore build failures seemed to be due to this problem.

Task ID: #

Test Plan:
make -C ffi/java

Reviewed By: mwilliams
Reviewers: mwilliams
CC: ps, mwilliams
Revert Plan:
Tags:

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

Differential Revision: 236510
  • Loading branch information
qixin authored and macvicar committed Apr 18, 2011
1 parent 11d0917 commit b0f06ae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/ffi/java/Makefile
Expand Up @@ -20,6 +20,7 @@ TARGETS = $(SHARED_LIB)
all : $(CLS) $(HEADER) $(TARGETS)

$(OBJECTS) : $(HEADER)
$(PIC_OBJECTS) : $(HEADER)

JAVA_PATH = /usr/local/jdk-6u7-64

Expand Down

0 comments on commit b0f06ae

Please sign in to comment.