Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLMarqueeLabel建议扩展增加左右图标和点击事件 #19

Closed
fg2q1q3q opened this issue Feb 10, 2020 · 4 comments
Closed

FLMarqueeLabel建议扩展增加左右图标和点击事件 #19

fg2q1q3q opened this issue Feb 10, 2020 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@fg2q1q3q
Copy link

目前的实现如果想加图标会非常不方便,建议flui直接扩展该功能,或者将slaveTextChild交由开发者自己处理,而不是目前固定成Text,局限性很大

@Rannie Rannie added the enhancement New feature or request label Feb 10, 2020
@Rannie
Copy link
Owner

Rannie commented Feb 10, 2020

@fg2q1q3q ok 这个会扩展

@fg2q1q3q
Copy link
Author

不好意思,我发现noticeBar有这个功能(只是不能更换图标),在使用noticeBar过程中发现一处bug,设置backgroundColor的时候会报错Color类型不能为bool类型,经查应该是如下代码中少了一个括号导致:
···
Color barBackgroundColor = backgroundColor ?? isDarkMode
? accent.withOpacity(0.2)
: FLNoticeBarBackgroundColor;
···

@Rannie Rannie added the bug Something isn't working label Feb 11, 2020
@Rannie
Copy link
Owner

Rannie commented Feb 11, 2020

@fg2q1q3q 这个问题我会跟一下,左右侧 Icon 的问题 noticebar 支持自定义的 prefixBuilder 和 suffixBuilder 的,你可以尝试下,文档我会在下个版本 1.0 尽量补充全

@Rannie
Copy link
Owner

Rannie commented Mar 13, 2020

0.9.0 fixed

@Rannie Rannie closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants