Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child-shell #116

Merged
merged 70 commits into from
Nov 7, 2021
Merged

child-shell #116

merged 70 commits into from
Nov 7, 2021

Conversation

rannn505
Copy link
Owner

@rannn505 rannn505 commented Apr 15, 2020

- Convert code base to Typescript
- Add .CONTIBUTE file to repo
- Improve library errors (fix #92)
- Fix invoke() promise never resolves bug (fix #94, fix #96)
- Add support to inject environment variables via constructor options
- more examples
- convert exit listener to rxjs
- add RotateStream
- fix options naming
- import PowerShell instead of NodePowerShell
- hooks options
- add setLogger abstract method
- ChildShell classes hooks
- NPS verbose
- convert options interfaces to types
- tsconfig.target ES6
- RotateStream _final
@Lundberg-Seth
Copy link

Any updates? Thanks again!

@DarkLite1
Copy link

It would be great if this could be merged. It seems to solve a lot of issues.
Thank you for the great work.

@krystofwoldrich
Copy link

Hi, hope you're doing well, what's missing for the release?

Any way I could help?

@ahmad-invozone
Copy link

@rannn505 When you would be able to merge this?

Facing many issues in v4. Few of them are already mentioned in this pull request:

@rannn505
Copy link
Owner Author

rannn505 commented Jul 4, 2021

Hi all,

I'm sorry the new version has been delayed so long. I've been very busy, so it's mostly time that I'm lacking to finish it.
Most of the code is written, but I still need to work on the examples and documentation since the library went through a complete rewrite and a lot of new and different things have been added.
I promise I'm going to do my best to get something preliminary so you can help me keep going.
In a month or two, I'll be able to approach it with a fresh, positive mind, as I usually do when writing open source.

Please accept my sincerest thanks for your patience and trust in me. I promise it will pay off, as I have a bunch of cool features up my sleeve. 🙏🏽

@ghost
Copy link

ghost commented Aug 14, 2021

Hello @rannn505 . I hope all well. Any news of releasing latest version! Thank you for your hard work.

@rannn505
Copy link
Owner Author

rannn505 commented Aug 15, 2021

Hi @davidhagen .
I will be back to work on it this week, and I believe the version will be ready sometime in September.

@netmastan
Copy link

netmastan commented Aug 16, 2021

I'm trying to restart machines and randomly getting the following error
case"restart":
ps.addCommand($GetProcessJob = Start-Job -FilePath "scripts\\restart.ps1" -Arg ${server},${vmname},${taskid});
ps.addCommand(Wait-Job $GetProcessJob | Out-Null);
ps.addCommand(Receive-Job -Job $GetProcessJob);
ps.invoke() //master.js 105
.then(output => {
res.send(output);
ps.dispose();
})
.catch(err => {
res.status(500).send(responseResult({'code': 500,'status':1, 'message': err.message}));
ps.dispose();
});
break;`

"stack": [ "Error [ERR_STREAM_WRITE_AFTER_END]: write after end", " at writeAfterEnd (_stream_writable.js:266:14)", " at Socket.Writable.write (_stream_writable.js:315:5)", " at c:\\Scripts\\myapp\\node_modules\\node-powershell\\lib\\utils.js:45:14", " at new Promise (<anonymous>)", **" at shellSafeWrite (c:\\Scripts\\myapp\\node_modules\\node-powershell\\lib\\utils.js:44:41)", " at Shell.invoke (c:\\Scripts\\myapp\\node_modules\\node-powershell\\lib\\Shell.js:188:5)",** " at c:\\Scripts\\myapp\\routes\\master.js:105:6", " at newFn (c:\\Scripts\\myapp\\node_modules\\express-async-errors\\index.js:16:20)", " at Layer.handle [as handle_request] (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\layer.js:95:5)", " at next (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\route.js:137:13)", " at Route.dispatch (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\route.js:112:3)", " at newFn (c:\\Scripts\\myapp\\node_modules\\express-async-errors\\index.js:16:20)", " at Layer.handle [as handle_request] (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\layer.js:95:5)", " at c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\index.js:281:22", " at Function.process_params (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\index.js:335:12)", " at next (c:\\Scripts\\myapp\\node_modules\\express\\lib\\router\\index.js:275:10)" ], "level": "error", "message": "uncaughtException: write after end", "timestamp": "2021-08-16T04:12:03.026Z"

@braden-wallace
Copy link

Any update on when this branch may be complete/merged in? @rannn505 thanks for the hard work!

@JiaweiTan
Copy link

@rannn505 Any updates? :)

@rannn505
Copy link
Owner Author

rannn505 commented Nov 8, 2021

Hi everybody,

Thanks for your patience, the current branch has been merged and released to npm as 5.0.0. 🚀
There is still work to be done on tests, documentation, examples, and roadmap building. I am currently working on those and will release them as soon as possible.
Meanwhile, you can check out the new API at the playground. ⛳
Please let me know your initial thoughts and any suggestions you may have. 💡

Once again, thank you for your care, 🙏🏽
Ran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment