Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18 Feature: add homepage option #31

Merged
merged 4 commits into from May 29, 2018
Merged

Conversation

vsashyn
Copy link
Contributor

@vsashyn vsashyn commented May 22, 2018

No description provided.

Copy link
Owner

@ranyitz ranyitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

  1. I think it worth removing the -h alias.
  2. We can mock opn using jest.mock and test that it gets the right argument.

src/cli.js Outdated
@@ -19,6 +19,7 @@ try {
'-w, --why',
'add information regarding why this package was installed',
)
.option('-h, --homepage', 'open the homepage of a certain module')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can remove the -h alias as it can be confused with the help option.

@ranyitz ranyitz mentioned this pull request May 25, 2018
@ranyitz ranyitz merged commit 981e910 into ranyitz:master May 29, 2018
@ranyitz
Copy link
Owner

ranyitz commented May 29, 2018

Thanks @vsashyn! 🎉

@ranyitz ranyitz mentioned this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants