Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update major dependencies and fix code accordingly: #59

Merged
merged 4 commits into from
Dec 20, 2020

Conversation

sidoruk-sv
Copy link
Contributor

@sidoruk-sv sidoruk-sv commented Dec 18, 2020

NOTE: a lot of upgraded packages requires Node.js v10 now so it could be breaking (otherwise, I could downgrade them to the versions where Node.js v8 is still supported).

  • commander:
    • add new default command (that is called when you invoke qnm [module]);
    • reorganize global options to separate section;
    • replace -V with -v for version;
  • fix typing problems;
  • new husky config;
  • fix lint for all files (caused by new prettier defaults);
  • cleanup package.json > files field:
    • do not pack src and build/__tests__ to the npm package;
    • Some entries are always included, regardless of settings.
  • remove redundant eslint rules (which was turned off);

For now -h,--help will return such content (you could compare with the current published on):

Usage: qnm [options] [command]

Options:
  -v, --version        output the current version
  -d, --debug          see full error messages, mostly for debugging
  -o, --open           open editor at the package.json of a chosen module
  --disable-colors     minimize color and styling usage in output
  --homepage           open module's homepage using the default browser
  -h, --help           display help for command

Commands:
  default [module]     prints module version from the node_modules
  install-completions  attempt to install tab completions using tabtab
  list [options]       list all node_modules with their versions
  match <string>       prints modules which matches the provided string
  help [command]       display help for command

* commander:
* * add new `default` command (that is called when you invoke `qnm [module]`);
* * reorganize global options to separate section;
* * add `-v` alias for version;
* fix fix typing problems;
* new husky config;
* fix lint for all files;
* cleanup package.json > "files" field (These files are always included, regardless of settings);
@sidoruk-sv sidoruk-sv force-pushed the update-major-dependencies branch 3 times, most recently from 9bc5b10 to d8670ba Compare December 18, 2020 04:39
@sidoruk-sv
Copy link
Contributor Author

@ranyitz WDYT?)
Especially part for Node.js v10 is required from now

Copy link
Owner

@ranyitz ranyitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks a lot, it looks great!
Appreciate the time went to doing it 😃

@ranyitz ranyitz merged commit bfec5b7 into ranyitz:master Dec 20, 2020
@sidoruk-sv sidoruk-sv deleted the update-major-dependencies branch December 20, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants