Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert order for processing patterns #1937

Closed
ghost opened this issue Aug 3, 2018 · 17 comments
Closed

Insert order for processing patterns #1937

ghost opened this issue Aug 3, 2018 · 17 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Aug 3, 2018

Issue description:

Some machines with multiple slots, e.g. the Slice'n'splice from EnderIO, required that the items are inserted in the correct order. Currently there seems to be no way to force the insertion order, so the crafting does not work.

What happens:

The pattern for a Skeletal Contractor requires the silicon to be in the middle slot in the bottom, but the silicon is inserted first in to the bottom left slot. The rotten flesh and skeleton head are not accepted.

What you expected to happen:

A way to force the insertion order so that rotten flesh is inserted first.

Steps to reproduce:

  1. Have a slice'n'splice with a crafter
  2. Create a pattern for a skeletal contractor, how the items are placed in the crafting grid does not matter.
  3. Request a craft of the skeletal contractor.
  4. Look in the slice'n'splice, the items are not in the correct slots.

Version (make sure you are on the latest version before reporting):

  • Minecraft: 1.12.2
  • Forge: 14.23.4.2739
  • Refined Storage: 1.6

Does this issue occur on a server? [yes/no]
A local LAN server, yes.

@CurlyFlow
Copy link

CurlyFlow commented Sep 14, 2018

Maybe just add the items in the order you put it in the crafting field...

Like:

1 2 3
4 5 6
7 8 9

So could just insert the first item in the upper left slot, then the second... i guess u get it. Would be an easy fix, i guess? And no one needs to change anything. Execpt the few receipes which order is important.

@DarkHelmet433
Copy link

I've had this problem with this machine in the past. I used to solve it by changing the order of the pattern so that the head always came first. Once the head was inserted, the remaining slots would only accept the correct item.

However in 1.6+ and the new EnderIO, I've literally used the recipe exactly as it's specfied in JEI.
I took a screenshot from my world showing this: https://i.imgur.com/X919G4S.png
In the past I've had to have the head in the top left slot of the pattern.

This machine is quirky at best.

@CurlyFlow
Copy link

The problems continue... alloy smelter... dark steel...

u need crushed coal, iron and obsidian... it first inserts crushed coal and iron... which gives steel...

@changhe3
Copy link

This would also be very useful for autocrafting using things like AA Empowerer.

@flapee
Copy link

flapee commented Nov 24, 2018

and for TiC casting table, if you want to specify the cast in the recipe as well; ATM it seems the crafter tries to push the liquid before the cast ...

@MarkusPriska
Copy link

Would also really like this feature as i kinda need it for automatic crafting

@starryknight64
Copy link

I was able to workaround this issue by hooking the crafter up to a chest and have the Slice'n'Splice accept input from the chest.

@Norway174
Copy link

Having the same problem. Seems like the Crafter will always output the Silicon first, no matter the ordering. Not sure why it selects the silicon first.

@starryknight64's workout doesn't work either, because the machine pulls in the first item from the chest, which is the silicone.

I think @eihns suggestion to use the ordering would be a good, intuitive fix. Which could also potentially solve many more problems, including this one.

@Salamance73
Copy link

I've come to solve this by using Refined Storage Silicon instead of Raw Silicon from Galacticraft, as the crafter outputs the items into my buffer chest in alphabetical order, meaning Raw Silicon would go before Rotten Flesh. At the moment this seems to work.

@StellaaNZ
Copy link

This has also become an issue in al132mc's mod Alchemistry with the combiner. The inputs need to be a specific order for the machine to create the correct item.

SmashingMods/Alchemistry#57

@Szasdragon
Copy link

This has also become an issue in al132mc's mod Alchemistry with the combiner. The inputs need to be a specific order for the machine to create the correct item.

al132mc/alchemistry#57

Tested some fake recipe patterns and found the Patern recipe not keeps the slot order when there are multiple stacks from same items (there is no difference between stackable and non-stackable). Instead the same items will be stacked together and break the recipe. The Slot Filler item is intended to elevate this issue, but the Crafter not place it correctly.
In the Tool tip window it is useful to see a shortened ingredient list, but for a machine which is sensitive for slot order it isn't.
image

@Scha7ten
Copy link

Scha7ten commented Jan 4, 2021

This has also become an issue in al132mc's mod Alchemistry with the combiner. The inputs need to be a specific order for the machine to create the correct item.
al132mc/alchemistry#57

Tested some fake recipe patterns and found the Patern recipe not keeps the slot order when there are multiple stacks from same items (there is no difference between stackable and non-stackable). Instead the same items will be stacked together and break the recipe. The Slot Filler item is intended to elevate this issue, but the Crafter not place it correctly.
In the Tool tip window it is useful to see a shortened ingredient list, but for a machine which is sensitive for slot order it isn't.
image

You can go around that problem if you set up the crafter with the combiner in a 1:1 ratio per recipe. Meaning: You lock 1 recipe in the combiner and set a crafter up for it with only a single pattern in it. am doing that right now in my playthrough of the chemical exchange modpack (i added some mods to it like flux networks, but nothing that changes rs' behavior). Alchemistry is a pain in the a to automate, but it is possible (and costly, cause if you want your system to run efficiently you need 8 speed upgrades per combiner, 4 in the crafter and 4 in an importer, as the crafter does not seem to pull the items out of the combiner, maybe because the combiner has a strange output slot, which can be filled up by the player with the result).

@Szasdragon
Copy link

@Scha7ten
Yeah... One combiner for everything in Antimater Chemistry modpack. I had to build minimum 30 or more combiner just for some recipe. I have the space for such system like this, but maintaining it is a nightmare. There is a solution for it. I prefer RS over AE, and it can be improve the mod.
For universal ingot forming, my work around is the Crafter output in a Hopper (side way or else it takes Paterns also), ant this is input to a Combiner. The Combiner is unlocked, so it always make any ingot. But Triglicerin like compounds I have to manually insert them.

@slacksystem
Copy link

Is this something that will be fixed in 1.12?

@Darkere
Copy link
Collaborator

Darkere commented Feb 21, 2021

No

@RobinVanTol
Copy link

Is this currently fixed for 1.16.5?

@Darkere
Copy link
Collaborator

Darkere commented Feb 2, 2022

Yes. Also for 1.18

@Darkere Darkere closed this as completed Feb 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.