Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SheetCollection class #34

Closed
rap2hpoutre opened this issue Jul 6, 2018 · 6 comments
Closed

Add SheetCollection class #34

rap2hpoutre opened this issue Jul 6, 2018 · 6 comments
Labels
easy enhancement New feature or request good first issue Good for newcomers

Comments

@rap2hpoutre
Copy link
Owner

Create a class SheetCollection that extends Collection with nothing more for now (so an empty class). It prepares the evolution of export/import system. See #24 (comment)

@rap2hpoutre rap2hpoutre added enhancement New feature or request good first issue Good for newcomers easy labels Jul 6, 2018
@rap2hpoutre rap2hpoutre added this to the Multiple sheets milestone Jul 6, 2018
@shoutoutloud
Copy link
Contributor

Hi. I can be helpful. What should I do?

@rap2hpoutre
Copy link
Owner Author

Thank you for your proposition! This ticket is a tiny task, but it prepares a greater feature!

Some more context: currently, we can only import and export one sheet. It's OK for simple cases, but it could be better if optionally, we could import/export more sheets. The original ticket is here: #29. After posting this ticket, I had a long (and really interesting) discussion with @Harti in this PR: #24, and we created a roadmap, thanks to our discussion, in this comment: #24 (comment).

So, I think you have to :

  • Read briefly the original tickets (mentioned above) to understand the context.
  • Create an empty SheetCollection class that extends Collection in src forder.
  • Send a PR when you created the file.
  • After that, if you want, we could tackle together the next issue: Export a collection or a sheet collection #35 (which is a bit more complex).

Feel free to ask me anything!

@shoutoutloud
Copy link
Contributor

@rap2hpoutre Thank you for elaborating things.I can create the SheetCollection class but I may not be of much help after that as I am just a newbie.

@rap2hpoutre
Copy link
Owner Author

No problem, it's OK!

@rap2hpoutre
Copy link
Owner Author

See: #36

@rap2hpoutre
Copy link
Owner Author

Fixed, available in v0.5.0 thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants