Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a collection or a sheet collection #35

Closed
rap2hpoutre opened this issue Jul 6, 2018 · 1 comment
Closed

Export a collection or a sheet collection #35

rap2hpoutre opened this issue Jul 6, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
Multiple sheets

Comments

@rap2hpoutre
Copy link
Owner

Improve "export" system, to accept either a collection and a sheet collection (a SheetCollection is just a collection of collections, but identified by its class). For now, it's in constructor, but it should be improved in a near future, because it's ugly and we will add a Façade. See: #24 (comment)

Must be done after #34
@rap2hpoutre rap2hpoutre added this to the Multiple sheets milestone Jul 6, 2018
@rap2hpoutre rap2hpoutre added the enhancement New feature or request label Jul 6, 2018
@rap2hpoutre rap2hpoutre mentioned this issue Jul 6, 2018
Closed
@rap2hpoutre
Copy link
Owner Author

FIxed via: 26b4da3 and b19bad5 🎊

Tested via unit tests.

See readme: https://github.com/rap2hpoutre/fast-excel#export-multiple-sheets

Ping @Harti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Multiple sheets
Development

No branches or pull requests
1 participant
@rap2hpoutre