Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for laravel daily logs #209

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Conversation

djunehor
Copy link
Contributor

In response to issue #202 where the package doesn't detect other log files deep in the year and month folders. I modified the package to generate an array of the directory structure with the files therein so user can click on any file to view logs.
Capture

@rap2hpoutre
Copy link
Owner

Hi @djunehor, thank you for your contribution! This would be a great enhancement of the log viewer indeed, thank you for your effort! 🎉 I will try to review it next week and merge it if everything is ok!

@EvilTwin01
Copy link

EvilTwin01 commented Dec 20, 2019

Hi, any update on this its been more than a week?

@juanpscotto
Copy link

Any news? I'm also waiting for this

@breaktag
Copy link

breaktag commented Mar 5, 2021

Any news? I am waiting on this too?

@djunehor
Copy link
Contributor Author

djunehor commented Mar 5, 2021

@rap2hpoutre I've resolved the conflict. Kindly review and merge

@breaktag
Copy link

@rap2hpoutre Please can you merge this?
Thank you :)

@starofsky
Copy link

@rap2hpoutre Please merge this PR and release new version. Thank you so much.

@moufakkir-zohair
Copy link

@rap2hpoutre Please can you merge this?
Thank you :)

1 similar comment
@1YalcinSahin1
Copy link

@rap2hpoutre Please can you merge this?
Thank you :)

@rap2hpoutre rap2hpoutre merged commit ce5b1d0 into rap2hpoutre:master Nov 4, 2021
@rap2hpoutre
Copy link
Owner

@djunehor @EvilTwin01 @juanpscotto @breaktag @starofsky @moufakkir-zohair @1YalcinSahin1
Thank you for your patience and sorry for the late answer. I just released a new version (2.0.0) that contains this change.

@djunehor Thank you so much for your contribution!

@1YalcinSahin1
Copy link

1YalcinSahin1 commented Nov 4, 2021

Thank you @rap2hpoutre but it didn't work properly for me @djunehor

It writing the whole path instead of the foldername.

@codisfy
Copy link

codisfy commented Apr 21, 2022

It also broke the nice glob pattern matching, with matching the expression by splitting pattern like strtolower(pathinfo($fileinfo->getRealPath(), PATHINFO_EXTENSION)) == explode('.', $pattern)[1]

Earlier a pattern like *.* would list all files now it doesn't show anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants