Swift 5 #57
Merged
Swift 5 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-swift5
branch
2 times, most recently
from
950d204
to
dc9efbd
Compare
This comment has been minimized.
This comment has been minimized.
MaximAlien
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Overall looks good to me. One minor thing is that I got warning when attempting to build using Xcode 12.0 stating that CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES; can be set.
Also as I can see Travis CI was updated to Xcode 12.2, but LastUpgradeVersion in project is Xcode 11.3. Both are not too important though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed a pro forma migration to Swift 5 and upgraded project settings to Xcode
11.312 recommendations.