Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on Apple platforms #66

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix builds on Apple platforms #66

merged 2 commits into from
Nov 5, 2020

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Nov 4, 2020

Added a missing file to the Xcode project, which is used by Carthage.

The Travis CI configuration didn’t catch the broken build because it was only building on Linux. A line in the configuration file was intended to make the build matrix exclude a build on macOS that lacks any of the environment variables that xcodebuild requires. However, it had the effect of canceling out each of the builds on macOS that were explicitly specified earlier in the file. The fix is to specify an empty environment variable for every build in the matrix, override it for the macOS-based builds we do want to include, and exclude the build that lacks such an override.

/cc @frederoni @MaximAlien

@1ec5 1ec5 added the build label Nov 4, 2020
@1ec5 1ec5 self-assigned this Nov 4, 2020
@1ec5 1ec5 mentioned this pull request Nov 4, 2020
@1ec5 1ec5 merged commit bc99b17 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant