Modernize buffer access #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43 fixed a Swift compiler warning about unsafely casting a buffer in memory by reinterpreting the data as an NSData, which has fewer safety checks. We got lucky until adding support for Linux in #55: on some systems, the string is stored in a format that’s inconsistent with NSData’s internal storage on Apple platforms. This resulted in undefined behavior and random crashes on Linux when calling
decodePolyline(_:precision:). As of Swift 5, the safer way to get random access into this buffer appears to beData.withUnsafeBytes(_:)and casting later./cc @frederoni @MaximAlien @erichoracek