Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge for v8.2.1 #243

Merged
merged 14 commits into from
May 20, 2024
Merged

merge for v8.2.1 #243

merged 14 commits into from
May 20, 2024

Conversation

raphaelquast
Copy link
Owner

@raphaelquast raphaelquast commented May 15, 2024

A first series of bugfixes for v8.2

🔨 Fixes

  • ❗Fix identification of default shape based on dataset size
  • ❗Fix issues with unmanaged artists on inset-maps
  • Explicitly check if norm is provided as string before setting data limits
  • Provide more descriptive (info) error message if data cannot be plotted
  • Avoid using classification bins as labels if a large number of bins is used (>30)
  • Make sure to resample colormaps in case more bins than colors are used
  • Avoid shape radius estimation if no data is set
  • Avoid unnecessary draw-triggers for datasets if the "all" layer is visible
  • Remove warning for widgets if backends other than "ipympl" are used

@raphaelquast raphaelquast linked an issue May 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 75.08%. Comparing base (2aa99c9) to head (d3c4183).
Report is 3 commits behind head on master.

Files Patch % Lines
eomaps/_maps_base.py 3.03% 32 Missing ⚠️
eomaps/eomaps.py 73.33% 4 Missing ⚠️
eomaps/_data_manager.py 50.00% 1 Missing ⚠️
eomaps/shapes.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   75.29%   75.08%   -0.22%     
==========================================
  Files          27       27              
  Lines       11817    11854      +37     
==========================================
+ Hits         8898     8900       +2     
- Misses       2919     2954      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphaelquast raphaelquast merged commit 02860ff into master May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inset maps do not render/plot stuff things outside the top api
1 participant