Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scikit-learn<1.1.0 #278

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Use scikit-learn<1.1.0 #278

merged 1 commit into from
Jun 18, 2022

Conversation

raphaelvallat
Copy link
Owner

Temporary fix for #272

We will need to revert these changes when the next stable version of scikit-learn is released (1.1.2): scikit-learn/scikit-learn#23608

@raphaelvallat raphaelvallat self-assigned this Jun 18, 2022
@raphaelvallat raphaelvallat added the bug 💥 Something isn't working label Jun 18, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #278 (d4c5d2c) into master (8825a21) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          19       19           
  Lines        3287     3287           
  Branches      523      523           
=======================================
  Hits         3254     3254           
  Misses         17       17           
  Partials       16       16           
Impacted Files Coverage Δ
pingouin/power.py 100.00% <ø> (ø)
pingouin/multicomp.py 100.00% <100.00%> (ø)
pingouin/parametric.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7481ab...d4c5d2c. Read the comment docs.

@raphaelvallat raphaelvallat merged commit 742f930 into master Jun 18, 2022
@raphaelvallat raphaelvallat deleted the sklearn_version branch June 18, 2022 18:47
@raphaelvallat raphaelvallat mentioned this pull request Jun 18, 2022
9 tasks
@poldrack
Copy link

it appears that the problem mentioned above was fixed in sklearn 1.1.2 - can this requirement be updated now?

@raphaelvallat
Copy link
Owner Author

Hi @poldrack — of course, please see #300

However, I am not planning to release a new version of Pingouin before at least 1-2 months.

Thanks,
Raphael

@poldrack
Copy link

gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants