Add aesthetic flexibility to plot_rm_corr #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @remrama, Thanks for opening the PR! Looks great. Two things:
|
Codecov ReportBase: 98.70% // Head: 98.70% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 18 18
Lines 3312 3312
Branches 537 537
=======================================
Hits 3269 3269
Misses 25 25
Partials 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Let me know when the PR is ready for review/merge 👍 |
|
Yep it's good for review! I made the suggested changes. |
raphaelvallat
approved these changes
Nov 24, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @raphaelvallat - I love the
plot_rm_corrfunction and needed some flexibility to change its scatter and line features (e.g., marker size and line width). I made a simple change to allow this, adding two sets of kwargs that get passed through to seaborn. Nothing about the defaults have changed, it just offers flexibility if desired.Sorry I didn't open an Issue first, it was just such a straight-forward change I thought I'd go for it. No pressure if you want to reject this idea.