Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves obscure numba bug with just replacing range -> zip #115

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

remrama
Copy link
Collaborator

@remrama remrama commented Dec 11, 2022

Solves an obscure numba bug (specifically in yasa.numba._corr) that was popping up for only some users/systems. See the madness in #107.

Note: I thought it would be best to add some new tests for this, but I looked and the current tests in test_numba.py do catch it. So it's really just specific to some systems that don't get run during the unittests.

@codecov-commenter
Copy link

Codecov Report

Base: 91.47% // Head: 91.47% // No change to project coverage 👍

Coverage data is based on head (4f18416) compared to base (806b08f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          22       22           
  Lines        2674     2674           
=======================================
  Hits         2446     2446           
  Misses        228      228           
Impacted Files Coverage Δ
yasa/numba.py 21.66% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat raphaelvallat linked an issue Dec 11, 2022 that may be closed by this pull request
@raphaelvallat raphaelvallat added bug 💥 Something isn't working URGENT ❗ To fix ASAP labels Dec 11, 2022
@raphaelvallat
Copy link
Owner

Awesome, thanks! Merging now.

@raphaelvallat raphaelvallat merged commit 9458bc5 into raphaelvallat:master Dec 11, 2022
@remrama remrama deleted the numba_bug branch December 11, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working URGENT ❗ To fix ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants