Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sameDay function #7

Merged
merged 2 commits into from
May 19, 2015

Conversation

israelst
Copy link
Contributor

No description provided.

It doesn't touch the calendar object, so it can be a model's private
function.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.54%) to 82.29% when pulling 227bc08 on israelst:sameDay-refactoring into 0966c2d on raphamorim:master.

@@ -4,6 +4,10 @@ var Range = require('./range'),
ical = require('ical2json'),
fs = require('fs');

function sameDay(date1, date2){
return date1.toDateString() === date2.toDateString();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice view!

@raphamorim
Copy link
Owner

Thanks @israelst

raphamorim added a commit that referenced this pull request May 19, 2015
@raphamorim raphamorim merged commit bdea0f6 into raphamorim:master May 19, 2015
@israelst israelst deleted the sameDay-refactoring branch May 19, 2015 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants