Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap everything inside an IIFE and UMD export #7

Closed
mauriciosoares opened this issue Aug 8, 2015 · 8 comments
Closed

Wrap everything inside an IIFE and UMD export #7

mauriciosoares opened this issue Aug 8, 2015 · 8 comments

Comments

@mauriciosoares
Copy link

Hey, nice project...

Today you export 2 global variables, the Contructor Inphinity and the instance inphinity. Should them both be in the global scope? maybe if you wrap everything into an IIFE you can only export the one that's actually gonna be used by the developer.

Also you can add UMD support on it, adding a simple snippet, or even add it to your build process (which is nicer in my opinion)

Cheers!

@raphamorim
Copy link
Owner

Yiips!

Good AND vital suggestion! Initially the code started using IIFFE. But I've removed to test the functions individually. In the end: I've forgotten to put back :/

I'll update this in next commit. Thanks @mauriciosoares !

@raphamorim
Copy link
Owner

Oh, about UMD support. I'll see.
Note: I like the build process option.

@mauriciosoares
Copy link
Author

borat-thumbs-up-meme-photos-2

@mauriciosoares
Copy link
Author

I was going to close this issue, but I'll keep it opened, so you can close it when you implement what you want :)

@raphamorim
Copy link
Owner

+1 in borat image hahaha

@raphamorim
Copy link
Owner

Updated in 4ca0773.
About UMD support, I'll create another issue and apply a reference here.

@raphamorim
Copy link
Owner

Anyway thanks @mauriciosoares :)

@mauriciosoares
Copy link
Author

great job! keep up the good work

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants