-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap everything inside an IIFE and UMD export #7
Comments
Yiips! Good AND vital suggestion! Initially the code started using IIFFE. But I've removed to test the functions individually. In the end: I've forgotten to put back :/ I'll update this in next commit. Thanks @mauriciosoares ! |
Oh, about UMD support. I'll see. |
I was going to close this issue, but I'll keep it opened, so you can close it when you implement what you want :) |
+1 in borat image hahaha |
Updated in 4ca0773. |
Anyway thanks @mauriciosoares :) |
great job! keep up the good work 😎 |
Hey, nice project...
Today you export 2 global variables, the Contructor
Inphinity
and the instanceinphinity
. Should them both be in the global scope? maybe if you wrap everything into an IIFE you can only export the one that's actually gonna be used by the developer.Also you can add UMD support on it, adding a simple snippet, or even add it to your build process (which is nicer in my opinion)
Cheers!
The text was updated successfully, but these errors were encountered: