Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto complete popup is same color of background in vim #63

Open
Kelvin945 opened this issue Jul 30, 2019 · 3 comments
Open

auto complete popup is same color of background in vim #63

Kelvin945 opened this issue Jul 30, 2019 · 3 comments

Comments

@Kelvin945
Copy link

Kelvin945 commented Jul 30, 2019

Is this intended behavior?

@folixg
Copy link
Contributor

folixg commented Aug 1, 2019

I just had a look at the history, the background color for the PMENU was added in a17b059, however this was done only for the gui, not for terminal vim. So there are now two different styles.

In gvim popups look like this:
20190801-112441_scrot

And in terminal vim like this:
20190801-112537_scrot

When changing the Pmenu and PmenuSel values for terminal vim so that they mimic the gui style like this:

hi Pmenu        ctermfg=NONE ctermbg=16 cterm=NONE guifg=NONE guibg=#19242f gui=NONE
hi PmenuSel     ctermfg=NONE ctermbg=60 cterm=NONE guifg=NONE guibg=#66747f gui=NONE

Terminal vim would display popups like this:
20190801-112644_scrot

I think that change would benefit the theme, what is your opinion @raphamorim? If you like it, I will submit a PR.

@raphamorim
Copy link
Owner

Sorry about the delay. I'm 👍 with the change, but I wonder if we could use colors from the palette for that

@folixg
Copy link
Contributor

folixg commented Aug 3, 2019

I simply copied the terminal color codes that were used in other places to represent the same gui colors (#19242f<->16, #66747f<->60). So I would assume that these are the closest to the RGB palette we can get with terminal colors. My screenshots are based on the xterm theme and maybe some other terminal emulator themes are more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants