Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"focus event" handling for tab/window navigation #434

Closed
mfbolus opened this issue Jan 26, 2024 · 6 comments
Closed

"focus event" handling for tab/window navigation #434

mfbolus opened this issue Jan 26, 2024 · 6 comments

Comments

@mfbolus
Copy link

mfbolus commented Jan 26, 2024

Thank you for your great work on this project!

I am not entirely sure if I am asking this the right way, but I use an editor from the terminal (currently playing with helix) which I have set to do things like save/format an active buffer when "focus" is moved away from the tab/window. This feature works in Alacritty, for example. I also see on the helix wiki that rio nominally supports this.

For whatever reason, while this feature works when I am using Alacritty, nothing gets triggered by focus events when I am editing within rio. I am not sure if there is a rio configuration I am missing. Has anyone else noticed this issue? Do you have any suggestions for where to start in debugging this behavior?

Best,
MFB

@raphamorim
Copy link
Owner

Thank you for the issue, @mfbolus!

Which version are you using and which OS?

@mfbolus
Copy link
Author

mfbolus commented Jan 28, 2024

@raphamorim , yes that would be useful information, wouldn't it?!

rio v0.0.34
macOS v14.3

@raphamorim
Copy link
Owner

@raphamorim , yes that would be useful information, wouldn't it?!

haha sometimes not 😆

Will take a look, I think i have ported it from Alacritty. will check and update her

@raphamorim
Copy link
Owner

I figured out, it was not implemented. I've added the support to windows and linux here 4ad69ff but still need to port to the new macos client (upcoming 0.1.0)

@mfbolus
Copy link
Author

mfbolus commented Jan 29, 2024

Wow, that was fast! Nice work. Thank you

@mfbolus mfbolus closed this as completed Jan 29, 2024
@mfbolus mfbolus reopened this Jan 29, 2024
@raphamorim
Copy link
Owner

Implemented in the main with the new macos version (0.1.0) but will take a time to release, meanwhile marking it done but with test and awaiting-release labels in the board https://github.com/users/raphamorim/projects/6/views/1

This change will be shipped along with other changes in the 0.1.0. Thanks for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants