Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate boundery logic #21

Merged
merged 6 commits into from
Feb 24, 2016
Merged

Encapsulate boundery logic #21

merged 6 commits into from
Feb 24, 2016

Conversation

israelst
Copy link
Collaborator

It improves readability. It's a good first step to start writing unit tests.

@israelst israelst mentioned this pull request Feb 23, 2016
Closed
@raphamorim
Copy link
Owner

That's nice, better to read, test and add document.querySelectorAll or similar to multiple elements.

raphamorim added a commit that referenced this pull request Feb 24, 2016
@raphamorim
Merge pull request #21 from raphamorim/encapsulate-boundery-logic
f9fee88 
Encapsulate boundery logic
@raphamorim raphamorim merged commit f9fee88 into master Feb 24, 2016
@raphamorim raphamorim deleted the encapsulate-boundery-logic branch February 24, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@israelst @raphamorim