Allow for easier WeakConcurrentMap subclassing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might not be required anymore once elastic/apm-agent-java#2137 is merged, thus will close it once it's merged. |
|
Not required anymore on our end, thus closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isPersistentClassLoadermethod is currentlyprivate, thus we can't reuse it when creating subclasses ofWeakConcurrentMap.This is definitely a very minor annoyance and was found when trying to provide a custom map through constructor, which is convenient when testing to be able to check when items are actually removed from the concurrent map.
Context : https://github.com/elastic/apm-agent-java/blob/012af603ce314abff0e04183cfaf61b537cf5495/apm-agent-plugin-sdk/src/main/java/co/elastic/apm/agent/sdk/weakmap/NullSafeWeakConcurrentMap.java#L47