Refresh credentials every half-duration #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, credentials last an hour. Previously, awsaml would refresh the credentials every hour minus ten seconds. This leaves the potential of a long-running command picking up those credentials right before they expire, and them expiring partway through running the command, and the command failing. Terraform is one such example. This change will refresh the credentials every half hour. This *should* guarantee that whenever a command is run, it has at least a half hour of useful life on the credential that it picks up from the credentials file. A bug still exists: The timer starts from the time awsaml launches, not from the time a user logs in. This is okay, because it should still guarantee more frequent updates than necessary to retain valid and recent credentials.
bturner-r7
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, credentials last an hour. Previously, awsaml would refresh
the credentials every hour minus ten seconds. This leaves the potential
of a long-running command picking up those credentials right before they
expire, and them expiring partway through running the command, and the
command failing. Terraform is one such example.
This change will refresh the credentials every half hour. This should
guarantee that whenever a command is run, it has at least a half hour of
useful life on the credential that it picks up from the credentials
file.
A bug still exists: The timer starts from the time awsaml launches, not
from the time a user logs in. This is okay, because it should still
guarantee more frequent updates than necessary to retain valid and
recent credentials.