Add account dropdown to the refresh container #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could not for the life of me get the value of req.params.account when using an optional path parameter. This change switches over to using query parameters. Not ideal, so i'll loop back around and try to get /refresh/:account? working.
We read in and parse the metadata file from disk, then pass it in to the refresh container as a property. This is not ideal, but from what I can see the `Storage` object only contains the current account at least while in the refresh route. Might loop back around and see about getting all account metadata in and out of `Storage`.
Having a seperate api endpoint for switching accounts was a bad idea. Turns out we can just use the existing `POST /configure`.
Not particularly happy with the dangling comma lint fixes on imports. We seem to have been pretty consistent with not having trailing commas on import blocks. Need this to pass tests though so they are happening.
Extracted most of the account switch button into its own component. There is still some left over code in the parent component. Specifically the submitConfigure function is currently passed into the new AccountSwitch function. Ideally, I would like to see this imported straight into the AccountSwitch sub-component. Binding the action has proved difficult.
No idea why `Storage.get('metadataUrls')` was only returning one
account when I did my first pass. Nevertheless they are all there.
Filesystem read has been replaced with a `Storage.get`.
Not sure why this passes linting locally but not on travis, oh well.
|
I'll take a look as soon as I get the chance. In the meantime do you mind updating the changelog file with the 2.2.0 changes? |
|
Updated changelog, thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor UI improvement which allows switching accounts from the refresh page. It adds a dropdown button at the top of the refresh page, populated with your accounts. Select your account from the dropdown and you are redirected through
select-roleand back to the refresh page.Note that this doesn't actually reduce the amount of clicks you have to perform, it just streamlines the process and - for me - feels a lot smoother. It feels like less of a context switch. This is also the groundwork for switching your role directly from the refresh page. Coming soon.
I preemptively created a release and cask so I can continue to merge to master until concurrent account support is complete.