This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Fix: Don't cache Mixlib::ShellOut #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmitchell-r7
changed the title
athompson-r7
approved these changes
Nov 21, 2016
rdickey-r7
reviewed
Nov 21, 2016
| @@ -10,16 +10,16 @@ GIT | |||
| PATH | |||
| remote: . | |||
| specs: | |||
| cassandra-utils (0.2.4) | |||
| daemon_runner (~> 0.2) | |||
| cassandra-utils (0.0.1) | |||
There was a problem hiding this comment.
I don't have a local VERSION file, so it reverted to the 0.0.1 version. As far as I know, this shouldn't break anything. @athompson-r7, any thoughts on this?
There was a problem hiding this comment.
Do this won't break anything. The next release should fix things.
There was a problem hiding this comment.
@rdickey-r7, we're using thor-scmversion to handle versioning in the CI job. It reads the version from tags in the Git repo, so the version in Gemfile.lock is ignored.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15 by switching
Mixlib::ShellOuttoDaemonRunner::ShellOut. The [daemon_runnergem(https://github.com/rapid7/daemon_runner) does the right thing and doesn't cache theMixlib::ShellOutinstance between executions.