Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOAR-11535] InputOutput Datetime Fix #156

Merged
merged 18 commits into from
Nov 30, 2022
Merged

Conversation

cmcnally-r7
Copy link
Contributor

@cmcnally-r7 cmcnally-r7 commented Nov 15, 2022

Proposed Changes

Description

Describe the proposed changes:

  • A fix for the InputOutputValidator that ensures the InputOutputValidator does not break for datetime inputs because of inconsistencies caused by yaml.safe_load()

PR Requirements

Developers, verify you have completed the following items by checking them off:

  • Unit tests written for any new or updated code
  • Version bumped within setup.py
  • Changelog entry added

Copy link

@jkaluza-rapid7 jkaluza-rapid7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, please write the tests

igorski-r7
igorski-r7 previously approved these changes Nov 22, 2022
jkaluza-rapid7
jkaluza-rapid7 previously approved these changes Nov 29, 2022
TKuzas-R7
TKuzas-R7 previously approved these changes Nov 29, 2022
Copy link
Contributor

@TKuzas-R7 TKuzas-R7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great boss

Copy link
Contributor

@TKuzas-R7 TKuzas-R7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! LGTM

@jkaluza-rapid7 jkaluza-rapid7 merged commit 19d812f into master Nov 30, 2022
@cmcnally-r7 cmcnally-r7 deleted the SOAR-11535_Datetime_Fix branch December 2, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants