[SOAR-12421] Name Validator #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
requested changes
Jan 11, 2023
igorski-r7
approved these changes
Jan 12, 2023
dlaverty-r7
approved these changes
Jan 12, 2023
cmcnally-r7
requested changes
Jan 12, 2023
| raise ValidationException("Name should not contain any whitespace characters.") | ||
| if not name.replace("_", "").isalnum(): | ||
| raise ValidationException("Name should only contain alphanumeric values.") | ||
| if len(name.split("_")) > 7: |
There was a problem hiding this comment.
Unsure if this is a better change lemme know what you think
Suggested change
| if len(name.split("_")) > 7: | |
| len_name = len(name.split("_")) | |
| if len_name > 7: |
There was a problem hiding this comment.
And obviously put the len_name variable at the top somewhere.
Comment on lines
+16
to
+17
| if len(name.split("_")) > 7: | ||
| raise ValidationException(f"Name is too long, 7 words or less: contains {str(len(name.split('_')))}") |
There was a problem hiding this comment.
Suggested change
| if len(name.split("_")) > 7: | |
| raise ValidationException(f"Name is too long, 7 words or less: contains {str(len(name.split('_')))}") | |
| if len_name > 7: | |
| raise ValidationException(f"Name is too long, 7 words or less: contains {str(len(name.split('_')))}") |
| raise ValidationException("Plugin name is missing.") | ||
| try: | ||
| NameValidator.validate_name(spec.spec_dictionary()["name"], plugin_name=True) | ||
| except Exception as error: |
There was a problem hiding this comment.
Is it possible to specify the type of error here or is it better to handle all exceptions and assume they are related to plugin name not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off: