Df 3668 url validator #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-mcadams
reviewed
Jan 3, 2020
lmilby-r7
previously requested changes
Jan 3, 2020
|
Could we also get a screen shot of the validator running. |
I prefer text output that I can copy and paste from but along with Luke's same reasoning. |
tylerslijboom-r7
force-pushed
the
df-3668-url-validator
branch
from
1b5959b
to
df78fde
Compare
tylerslijboom-r7
commented
Jan 3, 2020
mhofert-r7
approved these changes
Jan 13, 2020
lmilby-r7
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searches files for URLs, and then runs a HTTP HEAD request to test that the URL exists. Reports back any that give an HTTP return code in the 400s.
https://issues.corp.rapid7.com/browse/DF-3668
Testing
Tested on the following plugins: mimecast, jenkins, wordpress, att_cybersecurity_alienvault_otx, threatstack, thehive, trufflehog, digitalocean, docker_engine, dumbno, netmiko and a few others. The attached file below highlights the 3 cases in order:
URLS that exist and are valid
return code 403 URLs
rc 404 URLs
url-validator-script.txt
ScreenShot sample: