Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fixs for depreciation validator #77

Merged
merged 3 commits into from Jan 22, 2020
Merged

Grammar fixs for depreciation validator #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c119db6
SP
mhofert-r7 Jan 22, 2020
b9b3248
Apply suggestions from code review
mrinehart-r7 Jan 22, 2020
8ff7b65
Merge branch 'master' into workflow
mrinehart-r7 Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Expand Up @@ -3,4 +3,4 @@ __pycache__/
build/
dist/
insightconnect_integrations_validators.egg-info/
.Ds_Store
.DS_STORE
8 changes: 4 additions & 4 deletions icon_validator/rules/plugin_validators/description_validator.py
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ class DescriptionValidator(KomandPluginValidator):
@staticmethod
def validate_description(description):
if description.endswith("."):
raise Exception("Description ends with period when it should not.")
raise Exception("Description ends with a period when it should not.")
if description[0].islower():
raise Exception("Description should not start with a lower case letter.")
if description[0].isspace():
Expand Down Expand Up @@ -34,17 +34,17 @@ def validate_dictionary(dict_, dict_key):
try:
DescriptionValidator.validate_description(value["description"])
except Exception as e:
raise Exception(f"{dict_key} key '{key}'\'s description ends with period when it should not", e)
raise Exception(f"{dict_key} key '{key}'\'s description ends with a period when it should not", e)

@staticmethod
def validate_plugin_description(spec):
if "description" not in spec.spec_dictionary():
raise Exception("Plugin description is missing")
raise Exception("Plugin description is missing.")

try:
DescriptionValidator.validate_description(spec.spec_dictionary()["description"])
except Exception as e:
raise Exception("Plugin description not valid", e)
raise Exception("Plugin description is not valid.", e)

def validate(self, spec):
DescriptionValidator.validate_plugin_description(spec)
Expand Down