Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freegeoip test #67

Merged
merged 6 commits into from Nov 1, 2019
Merged

Freegeoip test #67

merged 6 commits into from Nov 1, 2019

Conversation

mrinehart-r7
Copy link
Contributor

Proposed Changes

Describe the proposed changes:

PR Requirements

Developers, verify you have completed the following items by checking them off:

Style

Review the style guide

Functional Checklist

  • Work fully completed
  • Functional
    • Any new actions/triggers include JSON test files in the tests/ directory created with ./run -c sample $action > tests/$action.json
    • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger ./run -T tests/example.json -d -j
      • All actions/triggers shortcut ./run -T all -d -j (use PR format at end)
    • Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger ./run -R tests/example.json -d -j
      • All actions/triggers shortcut ./run -R all -d -j (use PR format at end)

Assessment

You must validate your work to reviewers:

  1. Run make validate and make sure everything passes
  2. Run the assessment tool: ./run -A -R all -T all. For single action validation: ./run -A -R tests/my_action.json -T tests/my_action.json
  3. Copy (./run ... | pbcopy) and paste the output in a new post on this PR.
  4. Add UI screenshot of the workflow used for testing
  5. Add UI screenshot of the job output used for testing
  6. Add UI screenshot of the artifact (See rules in UI Checklist) used for testing

@mrinehart-r7 mrinehart-r7 merged commit 87bb9ac into master Nov 1, 2019
@mrinehart-r7 mrinehart-r7 deleted the freegeoip_test branch November 1, 2019 00:26
mberezin-r7 pushed a commit that referenced this pull request Jun 6, 2022
* Update help.md

* Update help.md

* Update help.md

* Update plugin.spec.yaml

* Add test json file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant