This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
LOG-8728 running saved query support on query commands #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcguinness-r7
approved these changes
Aug 25, 2017
stopal-r7
requested review from
ilyabiryukov-r7
and removed request for
scawley-r7
| log_keys = kwargs.get('log_keys') | ||
| querynick = kwargs.get('querynick') | ||
| lognick = kwargs.get('lognick') | ||
| loggroup = kwargs.get('loggroup') |
There was a problem hiding this comment.
Is this a logset? For naming consistency we should probably use the convention name
There was a problem hiding this comment.
There is a known issue with the naming of "loggroup", "lognick" and "querynick" in lecli. They are not related to shortcuts, logsets etc we have in the server side. And they are confusing at some sense. There is actually an open bug for this already. We could solve it in another PR or this one. However, we don't have the names to go for the moment.
| saved_query_id = kwargs.get('saved_query_id') | ||
| query_string = kwargs.get('query_string') | ||
| log_keys = kwargs.get('log_keys') | ||
| querynick = kwargs.get('querynick') |
There was a problem hiding this comment.
Same here, regards naming. Should it be 'query name' instead?
ilyabiryukov-r7
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds saved query support to various query related commands such as get events, get recentevents, query, tail events. This also extends validation of query commands.
There is some commit noise as I had to do some refactoring after bumping onto some code duplication on query module. Also let me know if you think there's a better way of refactoring this part of code.