db_nmap service state doesn't update when services no longer running

[jfennell-techempower]

Steps to reproduce

How'd you do it?

1. Run db_nmap -A -sV <host> against a host that has open ssh server running, with no firewall enabled.
2. Run services , look for the ssh service on that host, and confirm that the state is 'open'.
3. Disable ssh by running sudo service ssh stop on the host machine, then run db_nmap -A -sV <host> again. The output indicates that port 22 is closed.
4. Run services again, and this time confirm that the state of the service on port 22 is still open.

Expected behavior

• I would expect that services previously identified are updated when db_nmap reports that its associated port is closed. Particularly that the state column changes from 'open' to 'closed'.

This is the behavior if you specify just one port using -p, after disabling ssh. The state changes to closed.
db_nmap -A -sV -p22 <host>

• I would also expect that the info field for that service would also be cleared, as there is no longer a service listening on that port, though I recognize this is not the current behavior when running db_nmap -A -sV -p22 <host>.

Current behavior

What happens instead?
The state of port 22, as indicated by running services, is still 'open', even though the output of db_nmap indicates it is closed.

System stuff

Metasploit version

Framework: 5.0.25-dev-
Console : 5.0.25-dev-

I installed Metasploit with:

• Kali package via apt
• Omnibus installer (nightly)
• Commercial/Community installer (from http://www.rapid7.com/products/metasploit/download.jsp)
• Source install (please specify ruby version)

OS

Ubuntu 18.04

What OS are you running Metasploit on?
Ubuntu 18.04

[busterb]

Sounds reasonable, got a diff? I also added this as something to look at more closely in the future

[github-actions]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.