Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meterpreters Should No Longer Return TLV_TYPE_ADDR_TYPE When Resolving Hostnames #17249

Open
zeroSteiner opened this issue Nov 10, 2022 · 2 comments
Open

Meterpreters Should No Longer Return TLV_TYPE_ADDR_TYPE When Resolving Hostnames #17249

zeroSteiner opened this issue Nov 10, 2022 · 2 comments
Labels
breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. code quality Improving code quality not-stale Label to stop an issue from being auto closed payload

Comments

@zeroSteiner
Copy link
Contributor

Now that #17244 is landed, it's unnecessary for Meterepter's to return the TLV_TYPE_ADDR_TYPE when resolving hostnames. It appears to always be the value that was echoed to it and is redundant anways because the address is always 0 bytes long when it failed to resolve, 4 bytes long when it's IPv4 or 16 bytes long when it's IPv6. The information is redundant and should be omitted but that'd likely break backward compatibility so this ticket is our reminder.
@smcintyre-r7 smcintyre-r7 added payload code quality Improving code quality breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. easy not-stale Label to stop an issue from being auto closed and removed bug labels Nov 10, 2022
@ArkaprabhaChakraborty
Copy link

I want to grab this issue too :)

@adfoster-r7 adfoster-r7 removed the easy label Oct 30, 2023
@adfoster-r7
Copy link
Contributor

Taking off the easy flag as this isn't a ticket that can be actively worked on due to it being a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Features that are great, but will cause breaking changes and should be deployed on a large release. code quality Improving code quality not-stale Label to stop an issue from being auto closed payload
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeroSteiner @ArkaprabhaChakraborty @smcintyre-r7 @adfoster-r7