Difference in store_loot db behavior when connected remotely

[adfoster-r7]

Steps to reproduce

Noticed when testing #17374

When loot is stored, it persists locally:

metasploit-framework/lib/msf/core/auxiliary/report.rb

Lines 417 to 430 in 37fe3b9

	ws = (db ? myworkspace.name[0,16] : 'default')
	name =
	Time.now.strftime("%Y%m%d%H%M%S") + "_" + ws + "_" +
	(host || 'unknown') + '_' + ltype[0,16] + '_' +
	Rex::Text.rand_text_numeric(6) + '.' + ext
	name.gsub!(/[^a-z0-9\.\_]+/i, '')
	path = File.join(Msf::Config.loot_directory, name)
	full_path = ::File.expand_path(path)
	File.open(full_path, "wb") do |fd|
	fd.write(data)
	end

But when the ccache content and file name is sent to the remote DB, it creates an new path to stop naming conflicts:

metasploit-framework/lib/msf/core/web_services/servlet/loot_servlet.rb

Lines 39 to 45 in 04e8752

	def self.report_loot
	lambda {
	warden.authenticate!
	job = lambda { |opts|
	if opts[:data]
	filename = File.basename(opts[:path])
	local_path = File.join(Msf::Config.loot_directory, "#{SecureRandom.hex(10)}-#{filename}")

So the return result of store_loot is the locally chosen name:

/Users/user/metasploit-framework/spec/dummy/framework/config/loot/20221218123340_default_192.0.2.2_mit.kerberos.cca_549283.bin"

Whilst querying for loot shows the path as having a different prefix:

/Users/user/metasploit-framework/spec/dummy/framework/config/loot/c90fd2477aff93d8769f-20221218123340_default_192.0.2.2_mit.kerberos.cca_549283.bin

Expected behavior

I believe store_loot should generate a local file name - and send it to the remote db webservice.
We shuold then persist the loot contents locally using the chosen webservice file name.

Current behavior

What happens instead?

the result of store_loot differs to future loot queries

Metasploit version

msf6 auxiliary(scanner/winrm/winrm_login) > version
Framework: 6.2.31-dev-6f9ebe4068
Console  : 6.2.31-dev-6f9ebe4068

[github-actions]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[github-actions]

Thanks for your contribution to Metasploit Framework! We've looked at this issue, and unfortunately we do not currently have the bandwidth to prioritize this issue.

We've labeled this as attic and closed it for now. If you believe this issue has been closed in error, or that it should be prioritized, please comment with additional information.