You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Payload sizes are determined by calling payload_module.new.size, this operation doesn't apply normalization to the datastore for the module's options, which results in invalid behavior.
For example, any OptBool datastore options will always be set to true, since "false" is truthy. The fix would be to determine whether the datastore has been normalized in the size() method and normalize it if needed. This would remove the need for a bunch of existing hacks, but will require some sane defaults to be set for things like LHOST, otherwise the normalization will fail due to option validation errors.
The text was updated successfully, but these errors were encountered:
I don't think this is actually required anymore, at least not for bool, since OptBool, since this issue was created, now returns a true/false without normalization, not a string.
Payload sizes are determined by calling payload_module.new.size, this operation doesn't apply normalization to the datastore for the module's options, which results in invalid behavior.
For example, any OptBool datastore options will always be set to true, since
"false"
is truthy. The fix would be to determine whether the datastore has been normalized in thesize()
method and normalize it if needed. This would remove the need for a bunch of existing hacks, but will require some sane defaults to be set for things likeLHOST
, otherwise the normalization will fail due to option validation errors.The text was updated successfully, but these errors were encountered: