Disable attr_accessible security in favor of strong_params

MSP-11326

lib/metasploit/model/author.rb

@@ -6,7 +6,6 @@ module Metasploit::Model::Author
   include Metasploit::Model::Translation
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Search
 

lib/metasploit/model/authority.rb

@@ -17,7 +17,6 @@ module Metasploit::Model::Authority
   autoload :Zdi
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Search
 

lib/metasploit/model/email_address.rb

@@ -6,7 +6,6 @@ module Metasploit::Model::EmailAddress
   include Metasploit::Model::Translation
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Derivation
     include Metasploit::Model::Search

lib/metasploit/model/module/action.rb

@@ -6,7 +6,6 @@ module Metasploit::Model::Module::Action
   include Metasploit::Model::Translation
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Search
 

lib/metasploit/model/module/ancestor.rb

@@ -54,7 +54,6 @@ module Metasploit::Model::Module::Ancestor
   SHA1_HEX_DIGEST_REGEXP = /\A[0-9a-z]{40}\Z/
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include ActiveModel::Validations::Callbacks
     include Metasploit::Model::Derivation

lib/metasploit/model/module/path.rb

@@ -9,7 +9,6 @@ module Metasploit::Model::Module::Path
 
   included do
     include ActiveModel::Dirty
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include ActiveModel::Validations::Callbacks
     include Metasploit::Model::RealPathname

lib/metasploit/model/module/rank.rb

@@ -27,7 +27,6 @@ module Metasploit::Model::Module::Rank
   NAME_BY_NUMBER = NUMBER_BY_NAME.invert
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Search
 

lib/metasploit/model/module/target.rb

@@ -10,7 +10,6 @@ module Metasploit::Model::Module::Target
   autoload :Platform
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Search
 

lib/metasploit/model/platform.rb

@@ -85,7 +85,6 @@ module Metasploit::Model::Platform
   }
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Derivation
     include Metasploit::Model::Search

lib/metasploit/model/reference.rb

@@ -6,7 +6,6 @@ module Metasploit::Model::Reference
   include Metasploit::Model::Translation
 
   included do
-    include ActiveModel::MassAssignmentSecurity
     include ActiveModel::Validations
     include Metasploit::Model::Derivation
     include Metasploit::Model::Search

spec/support/shared/examples/metasploit/model/author.rb

@@ -9,10 +9,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:name) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :name, :type => :string

spec/support/shared/examples/metasploit/model/authority.rb

@@ -33,13 +33,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:abbreviation) }
-    it { should allow_mass_assignment_of(:obsolete) }
-    it { should allow_mass_assignment_of(:summary) }
-    it { should allow_mass_assignment_of(:url) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :abbreviation, :type => :string

spec/support/shared/examples/metasploit/model/email_address.rb

@@ -22,12 +22,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:domain) }
-    it { should allow_mass_assignment_of(:full) }
-    it { should allow_mass_assignment_of(:local) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :domain, :type => :string

spec/support/shared/examples/metasploit/model/module/action.rb

@@ -9,10 +9,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:name) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :name, :type => :string

spec/support/shared/examples/metasploit/model/module/ancestor.rb

@@ -423,33 +423,6 @@ def attribute_type(attribute)
     end
   end
 
-  context 'mass assignment security' do
-    it 'should not allow mass assignment of full_name since it must match derived_full_name' do
-      module_ancestor.should_not allow_mass_assignment_of(:full_name)
-    end
-
-    it { should allow_mass_assignment_of(:handler_type) }
-    it { should allow_mass_assignment_of(:module_type) }
-
-    it 'should not allow mass assignment of payload_type since it must match derived_payload_type' do
-      module_ancestor.should_not allow_mass_assignment_of(:payload_type)
-    end
-
-    it 'should allow mass assignment of real_path to allow derivation of module_type and reference_name' do
-      module_ancestor.should allow_mass_assignment_of(:real_path)
-    end
-
-    it 'should not allow mass assignment of real_path_modified_at since it is derived' do
-      module_ancestor.should_not allow_mass_assignment_of(:real_path_modified_at)
-    end
-
-    it 'should not allow mass assignment of real_path_sha1_hex_digest since it is derived' do
-      module_ancestor.should_not allow_mass_assignment_of(:real_path_sha1_hex_digest)
-    end
-
-    it { should_not allow_mass_assignment_of(:parent_path_id) }
-  end
-
   context 'validations' do
     subject(:module_ancestor) do
       # Don't use factory so that nil values can be tested without the nil being replaced with derived value

spec/support/shared/examples/metasploit/model/module/path.rb

@@ -122,12 +122,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:gem) }
-    it { should allow_mass_assignment_of(:name) }
-    it { should allow_mass_assignment_of(:real_path) }
-  end
-
   context 'validations' do
     context 'directory' do
       let(:error) do

spec/support/shared/examples/metasploit/model/module/rank.rb

@@ -53,11 +53,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:name) }
-    it { should allow_mass_assignment_of(:number) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :name, :type => :string

spec/support/shared/examples/metasploit/model/module/target.rb

@@ -10,10 +10,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:name) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :name, :type => :string

spec/support/shared/examples/metasploit/model/platform.rb

@@ -148,10 +148,6 @@
     it_should_behave_like 'derives', :fully_qualified_name, :validates => true
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:relative_name) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute',

spec/support/shared/examples/metasploit/model/reference.rb

@@ -176,11 +176,6 @@
     end
   end
 
-  context 'mass assignment security' do
-    it { should allow_mass_assignment_of(:designation) }
-    it { should allow_mass_assignment_of(:url) }
-  end
-
   context 'search' do
     context 'attributes' do
       it_should_behave_like 'search_attribute', :designation, :type => :string