Skip to content

remove unused boxing and unboxing #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

remove unused boxing and unboxing #464

merged 1 commit into from
Mar 4, 2021

Conversation

@XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Feb 11, 2021

No description provided.

@gwillcox-r7
Copy link
Contributor

gwillcox-r7 commented Feb 19, 2021

So looking at https://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#valueOf(boolean) really this could go either way, as in both cases your looking at a case of a new Boolean instance being created. So really this comes down to a matter of readability and personal preference here.

That being said given that the change seems to be using an API specifically designed for the exact scenario we are dealing with here I'm inclined to say that it would be good form to accept this change mainly cause using new everywhere when we could be using a API dedicated to the task is not only bad form but could result in code optimizations that may be made by these specialized functions not being fully utilized by our code.

Changes are approved, will merge this in soon.

XenoAmess
XenoAmess commented Feb 19, 2021
View reviewed changes
Copy link
Contributor Author

@XenoAmess XenoAmess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwillcox-r7 wait a minute please

@gwillcox-r7
Copy link
Contributor

gwillcox-r7 commented Feb 19, 2021 •
edited
Loading

@XenoAmess will do, holding off due to rapid7/metasploit-framework#14780 needing to be tested and landed first. Feel free to comment or make suggestions to this PR in the meantime. 👍

@XenoAmess XenoAmess force-pushed the remove_unused_boxing_and_unboxing branch from be72408 to 0648c15 Compare February 19, 2021 17:09
@XenoAmess XenoAmess force-pushed the remove_unused_boxing_and_unboxing branch from 0648c15 to 5b4782c Compare February 19, 2021 17:14
@timwr timwr merged commit 7691f6f into rapid7:master Mar 4, 2021
@zeroSteiner zeroSteiner mentioned this pull request Mar 5, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gwillcox-r7 gwillcox-r7 gwillcox-r7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XenoAmess @gwillcox-r7 @timwr