fix bug where env lookups not found return garbage #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgoldman-r7
force-pushed
the
fix-env-variable-lookup-not-found
branch
from
928f94f
to
a40026e
Compare
zgoldman-r7
force-pushed
the
fix-env-variable-lookup-not-found
branch
from
a40026e
to
670fd69
Compare
adfoster-r7
reviewed
Jun 15, 2023
c/meterpreter/source/extensions/stdapi/server/sys/config/config.c
Outdated
Show resolved
Hide resolved
Co-authored-by: adfoster-r7 <60357436+adfoster-r7@users.noreply.github.com>
smcintyre-r7
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Changes look good to me. Thanks for fixing this @zgoldman-r7
meterpreter > getenv DOESNOTEXIST
[-] None of the specified environment variables were found/set.
meterpreter > getenv USERNAME
Environment Variables
=====================
Variable Value
-------- -----
USERNAME DC$
meterpreter >
zeroSteiner
added a commit
to zeroSteiner/metasploit-framework
that referenced
this pull request
Jun 20, 2023
Includes changes from: * rapid7/metasploit-payloads#662 * rapid7/metasploit-payloads#660
sempervictus
pushed a commit
to sempervictus/metasploit-framework
that referenced
this pull request
Aug 1, 2023
Includes changes from: * rapid7/metasploit-payloads#662 * rapid7/metasploit-payloads#660
JustAnda7
pushed a commit
to JustAnda7/metasploit-framework
that referenced
this pull request
Sep 20, 2023
Includes changes from: * rapid7/metasploit-payloads#662 * rapid7/metasploit-payloads#660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in framework where looking up an environment variable that doesn't exist doesn't cause an error, and instead returns unintelligible nonsense.
Tested on Windows 2016 Server VM, mac host machine
Setup:
Before:
After: