Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable line numbers with recog_verify (and possibly other) warn/fail output #389

Closed
dabdine opened this issue Dec 5, 2021 · 1 comment
Closed

Comments

@dabdine
Copy link
Contributor

dabdine commented Dec 5, 2021

Is your feature request related to a problem? Please describe.
recog_verify does not produce line numbers, making it difficult to identify which fingerprints are problematic when running the command. For example:

xml/http_servers.xml: WARN: 'Apache' is missing an example that checks for parameter 'service.version' which is derived from a capture group
xml/http_servers.xml: WARN: 'Apache' is missing an example that checks for parameter 'apache.info' which is derived from a capture group
xml/http_servers.xml: WARN: 'Microsoft IIS 1.0 - 4.0 runs on Windows NT 4.0' is missing an example that checks for parameter 'service.version' which is derived from a capture group
xml/http_servers.xml: WARN: 'Microsoft IIS new, unknown Windows version' is missing an example that checks for parameter 'service.version' which is derived from a capture group
xml/http_servers.xml: WARN: 'Microsoft .NET Remoting and Common Language Runtime (CLR)' is missing an example that checks for parameter 'service.component.version' which is derived from a capture group

Describe the solution you'd like
Make recog_verify produce line numbers when it encounters an issue.

Describe alternatives you've considered
None.

dabdine added a commit to dabdine/recog that referenced this issue Dec 5, 2021
@mkienow-r7
Copy link
Contributor

mkienow-r7 commented Dec 6, 2021

Thanks for opening the issue. I've thought about this while sifting through recog_verify output! A simple inline line number would be nice.
xml/http_servers.xml:$LINE_NUM: WARN: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants