Correct Cisco PIX fingerprints to use OS rather than service fingerprint #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
The changes look good. That being said the FP where a PIX munges the banners are suspect. IIRC, it routes the traffic through the firewall (as opposed to proxying the service) which means the target IP has a PIX in front of it, but isn't a PIX itself. https://blogs.it.ox.ac.uk/networks/2009/11/26/cisco-firewall-smtp-fixup-considered-harmful/comment-page-1/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code from which these recog fingerprints were derived expects Cisco PIX fingerprints to be for OS rather than service, which aligns with what is done in CPE. Why these were done with service looks like to be an oversight.