Correct F5 fingerprints #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwiseman-r7
reviewed
Aug 24, 2018
There was a problem hiding this comment.
On the InsightVM/Nexpose side of things we have a large number of checks that rely on the OS vendor value being F5 and family being BIG-IP. So removing " Labs" makes things more consistent from that point of view 👍
The changes from os to service shouldn't affect vulnerability results at all. Even though our checks use OS-level fingerprints, they won't fire from recog matches (they rely on an additional system config value to be asserted, which corresponds to what these files call product (e.g. LTM).
| @@ -287,8 +287,9 @@ | |||
| <fingerprint pattern="^.*(?:Basic|Digest) .*realm="BIG-IP".*$"> | |||
| <description>Generic F5 Big-IP</description> | |||
| <example>Basic realm="BIG-IP"</example> | |||
| <param pos="0" name="os.vendor" value="F5"/> | |||
| <param pos="0" name="os.product" value="BIG-IP"/> | |||
| <param pos="0" name="servicevendor" value="F5"/> | |||
gwiseman-r7
approved these changes
Aug 24, 2018
|
Good catch. I'll see about adding a test to catch possibly bad fingerprints like that. |
|
This was landed, but for some reason it is not showing up here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other fingerprints the vendor is F5, which is more correct. This makes the vendor name consistent.
This also uses the BIG-IP family and BIG-IP LTM product consistently, and corrects a handful of
osfingerprints that should beservice.