Banner update: HTTP - 2018.08.13 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhart-r7
reviewed
Aug 31, 2018
| <param pos="0" name="os.device" value="Firewall"/> | ||
| <param pos="0" name="os.family" value="Firewall-1"/> | ||
| <param pos="0" name="os.product" value="Firewall-1"/> | ||
| <param pos="0" name="os.product" value="GAiA OS"/> |
There was a problem hiding this comment.
Had to look this up to confirm. 👍
jhart-r7
reviewed
Aug 31, 2018
xml/http_servers.xml
Outdated
| </fingerprint> | ||
| <fingerprint pattern="^IdeaWebServer\/v?([\d.]+)$"> | ||
| <description>Idea Web Server</description> | ||
| <example>IdeaWebServer/0.83</example> |
There was a problem hiding this comment.
Minor, no example, not much different from what is already there.
There was a problem hiding this comment.
Not sure I understand this comment. Did you mean that the following two examples aren't different enough to warrant needing them?
jhart-r7
approved these changes
Aug 31, 2018
| <description>nginx with version info and/or mods</description> | ||
| <example service.version="0.8.53">nginx/0.8.53 + Phusion Passenger 3.0.0 (mod_rails/mod_rack)</example> | ||
| <example>nginx/0.8.53</example> | ||
| <example>nginx + Phusion Passenger 5.1.11</example> |
There was a problem hiding this comment.
Strange. So we get an empty string for the version here? May be worth two fingerprints, one with a version, one without.
There was a problem hiding this comment.
We have quite a few other fingerprints that can have an empty capture if the value isn't there. If you like I can split this one up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a banner update of the
http_servers.xmlfile using data from a Project Sonar survey of HTTP on port 80 that occurred on 2018.08.13.There are additional tweaks to support CPE generation as well as add
hw.deviceand similar fields where possible.Note: I am unsure as to why the CPE ordering changed.