Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-language recog verify to GitHub verify workflow #375

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Oct 6, 2021

Description

Enhances the GitHub verify workflow to run Ruby, Java and Go implementations of the recog fingerprint verification tool on any modified XML fingerprint files. This will help contributors and pull request reviewers verify at a minimum that each fingerprint example is matched and all parameters that are defined by capture groups have the expected value. Note, warnings are currently disabled in the tools that provide warnings (Ruby and Java), and will be enabled once all of the warnings in the existing fingerprints are corrected.

Motivation and Context

Help contributors and pull request reviewers catch concerns.

How Has This Been Tested?

  1. Opened PR against my recog fork
  2. Patched xml/ fingerprints to introduce issues
  3. Committed and pushed changes
  4. Confirmed Ruby Verify, Java Verify, and Go Verify workflow jobs all failed
  5. Committed and pushed changes to undo the changes applied by the patch
  6. Confirmed all Verify workflows were not run since xml files under xml/ were no longer different

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Copy link
Contributor

@tsellers-r7 tsellers-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great step forward

@mkienow-r7 mkienow-r7 merged commit 9cd63c2 into rapid7:master Oct 7, 2021
@mkienow-r7 mkienow-r7 deleted the feature/multi-lang-verify-ci-job branch October 7, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants