Restore non-capturing groups to fix anchored regex issue #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores non-capturing groups removed in #381 to fix issues where the anchors will only apply to the immediate value they are next to rather than the sequence of values in an OR match. The tests on the previous PR passed since the examples do not contain any leading or trailing text. Thanks to @dmoinescu-r7 for drawing attention to the issue.
Example
^NETIASPOT Management Console|Konsola zarzdzania NETIASPOT$"
matches the following strings:^(?:NETIASPOT Management Console|Konsola zarzdzania NETIASPOT)$
only matches the following strings:Motivation and Context
Fix regex issue.
How Has This Been Tested?
bundle exec ./bin/recog_verify FILENAME
rake tests
Types of changes
Checklist: