-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHCP fingerprints for Aruba sensors #500
Conversation
xml/dhcp_vendor_class.xml
Outdated
<example>Aruba-Sensor</example> | ||
<param pos="0" name="hw.vendor" value="Aruba Networks"/> | ||
<param pos="1" name="hw.model"/> | ||
<param pos="0" name="hw.device" value="Sensor"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "Network Management Device" be a better classification than "Sensor"? They are mentioned with the text "network management device" on CDW's website, but I was unable to locate such language on Aruba's website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took that text from the Aruba site. Other sites (resellers, presumably) have different descriptions - for instance, model Q9X65A is described in various places as:
- LTE Sensor
- LTE Sensor - wireless network management device
- LTE Wireless Sensor Network Management Device
- User Experience Insight LTE Sensor
- UXI sensor
The full description for the other 2 models mentioned in examples (R3R67A, R7H75A) seems to be User Experience Insight Sensor G-Series - wireless network management device.
So I think both sensor
and network management device
are reasonable descriptions. I don't have a strong opinion on the matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get another opinion I contacted @TomSellers who agreed both are correct, but "Network Management Device" would be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated hw.device
to "Network Management Device"
5c56ec6
to
cf38ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @dmoinescu-r7!
Description
New DHCP fingerprints for Aruba sensors, based on data observed inside DHCP packets.
How Has This Been Tested?
Ran
rake tests
,recog_verify
,recog_standardize
andupdate_cpes.py
Types of changes
Checklist: