Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castopod favicon fingerprint #516

Merged
merged 1 commit into from Dec 9, 2022
Merged

Castopod favicon fingerprint #516

merged 1 commit into from Dec 9, 2022

Conversation

todb
Copy link

@todb todb commented Dec 9, 2022

Description

Add a fingerprint for Castopod based entirely on the favicon

Notes

<link rel="icon" type="image/x-icon" href="/favicon.ico" />

This was pulled from the current-latest of Castopod, version 1.0.2.

Alas, there were no interesting cookies or <title> tags to sample -- Castopod is built using CodeIgniter and just uses a ci_session session cookie without renaming, and <title> tags are entirely custom to the content being hosted.

Motivation and Context

After Twitter changed ownership October of 2022, Fediverse services kind of exploded all over the internet. It would be nice to track them. I suspect there are a lot of new server operators who are diving into the deep end of self-hosted services.

How Has This Been Tested?

Collected the MD5 of the favicon, hoping for the best! I need to figure out how to test locally.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7
Copy link
Contributor

@todb as for local testing at a minimum you should run 1. bundle exec ./bin/recog_verify on the modified files, and 2. rake tests

Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @todb!

@mkienow-r7 mkienow-r7 merged commit c3e3953 into main Dec 9, 2022
@mkienow-r7 mkienow-r7 deleted the feature/castopod branch December 9, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants