Improve some SMTP fingerprints #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhart-r7
changed the title
| <example>foo.example.com ESMTP</example> | ||
| <example>foo.example.com ESMTP Ready</example> | ||
| <example>foo.example.com SMTP</example> | ||
| <fingerprint pattern="^(\S+) E?SMTP Perl" flags="REG_ICASE"> |
There was a problem hiding this comment.
Is this fingerprint useful to have?
There was a problem hiding this comment.
What I think you are eluding to is what I meant to do -- asserting host.name is useful but just Perl for the service fingerprint isn't useful (at least not today). I could go either way.
There was a problem hiding this comment.
Got it, thanks! Makes sense just to get host.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/CC @alynn71 @gwiseman-r7