DCA-1216: Windows 10 Fingerprint #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkennedy-r7
commented
Jun 23, 2015
jkennedy-r7
commented
- Added fingerprints for Windows 10 and Windows 10 Preview Edition
* Added fingerprints for Windows 10 and Windows 10 Preview Edition
|
What does "DCA-1216" mean? internal bug tracker? Answer: yes |
todb-r7
pushed a commit
that referenced
this pull request
Jun 23, 2015
|
Took a look at CONTRIBUTING.md, looks like landing should be pretty much identical to metasploit-framework, so did that. |
| <param pos="2" name="os.build"/> | ||
| </fingerprint> | ||
|
|
||
| <fingerprint pattern="^Windows 10 (\w+|\w+ \w+|\w+ \w+ \w+) (\d+)$"> |
There was a problem hiding this comment.
Minor, but I think this would have been better off combined with the previous fingerprint -- they both assert a Windows 10 fingerprint, the only difference is the first one includes support for Insider Preview in the regex. Simply make that part optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.