Default console width when api is unavailable #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
default-console-width-when-api-unavailable
branch
from
58372c6
to
0e1313c
Compare
adfoster-r7
commented
Jan 19, 2021
| @@ -70,8 +71,7 @@ def initialize(opts = {}) | |||
| # updated below if we got a "Rows" option | |||
| self.rows = [] | |||
|
|
|||
| # TODO: Discuss a cleaner way to handle this information | |||
| self.width = opts['Width'] || ::IO.console.winsize[1] | |||
| self.width = opts['Width'] || ::IO.console&.winsize&.[](1) || ::BigDecimal::INFINITY | |||
There was a problem hiding this comment.
Safe navigation of arrays has quirky syntax IMO. I believe if console is defined, winsize should be a valid array:
Suggested change
| self.width = opts['Width'] || ::IO.console&.winsize&.[](1) || ::BigDecimal::INFINITY | |
| self.width = opts['Width'] || ::IO.console&.winsize[1] || ::BigDecimal::INFINITY |
However - I'll err on the side of caution though, in case there's cross-platform differences.
There was a problem hiding this comment.
Checking the code it doesn't seem like this scenario should arise, but i'm not strongly opinionated
|
Confirmed that this fixes my original issue. Thanks! |
adfoster-r7
force-pushed
the
default-console-width-when-api-unavailable
branch
from
0e1313c
to
b6c799e
Compare
adfoster-r7
force-pushed
the
default-console-width-when-api-unavailable
branch
from
b6c799e
to
17f6728
Compare
adfoster-r7
commented
Jan 19, 2021
| @@ -42,31 +42,32 @@ def with_whitespace_highlighted(string) | |||
|
|
|||
| describe Rex::Text::Table do | |||
| let(:formatter) do | |||
| Formatter = Class.new do | |||
There was a problem hiding this comment.
Just fixing these whilst I'm here, this was creating constant warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #34